Skip to content

tests: fix polars regex in with_columns, filter and select tests#2844

Merged
MarcoGorelli merged 1 commit intonarwhals-dev:mainfrom
EdAbati:tests/fix-polars-regex
Jul 17, 2025
Merged

tests: fix polars regex in with_columns, filter and select tests#2844
MarcoGorelli merged 1 commit intonarwhals-dev:mainfrom
EdAbati:tests/fix-polars-regex

Conversation

@EdAbati
Copy link
Collaborator

@EdAbati EdAbati commented Jul 17, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

The regex is a bit too strict and makes the test fail for polars==0.20.22 in the random version workflow

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @EdAbati !

@MarcoGorelli MarcoGorelli merged commit 4a8551e into narwhals-dev:main Jul 17, 2025
34 checks passed
@EdAbati EdAbati deleted the tests/fix-polars-regex branch July 17, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants