Skip to content

chore: Remove unreachable hash check #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoGorelli merged 2 commits into from
Jun 28, 2025
Merged

chore: Remove unreachable hash check #2750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf09822
chore: Do we really have coverage?
dangotbanned Jun 28, 2025
d610182
Merge branch 'main' into cov-check_column_names_are_unique
dangotbanned Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions narwhals/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,13 +1573,7 @@ def check_columns_exist(


def check_column_names_are_unique(columns: Collection[str]) -> None:
try:
len_unique_columns = len(set(columns))
except TypeError as exc: # pragma: no cover
msg = f"Expected hashable (e.g. str or int) column names, got: {columns}"
raise TypeError(msg) from exc

if len(columns) != len_unique_columns:
if len(columns) != len(set(columns)):
from collections import Counter

counter = Counter(columns)
Expand Down
Loading