Skip to content

chore: Simplify PandasLikeGroupBy #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 86 commits into from
Jul 14, 2025
Merged

chore: Simplify PandasLikeGroupBy #2680

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
a7f2559
refactor: Move errors, warnings outside of `PandasLikeGroupBy.agg`
dangotbanned Jun 15, 2025
c61e09e
refactor: Split out complex, add some typing
dangotbanned Jun 15, 2025
c530b85
refactor: Split out dupe code to `_select_results`
dangotbanned Jun 15, 2025
294c6de
docs: Note the current complexity counts
dangotbanned Jun 15, 2025
745eccd
cov
dangotbanned Jun 15, 2025
d9cfa76
feat(typing): Add `NativeAggregation` literal
dangotbanned Jun 15, 2025
839cfb6
chore(typing): "Add typing" for the rest
dangotbanned Jun 15, 2025
13d900c
Experimenting with named agg style
dangotbanned Jun 15, 2025
6707d2d
refactor: Nice generalized version that "works"
dangotbanned Jun 15, 2025
d941e74
Mostly clean slate re-impl
dangotbanned Jun 16, 2025
f222cac
fix: Resolve 15/21 failures
dangotbanned Jun 16, 2025
a62e58f
note the remaining issues
dangotbanned Jun 16, 2025
6951889
test: Update to use `DuplicateError`
dangotbanned Jun 16, 2025
e313f2b
refactor: Remove dead code
dangotbanned Jun 16, 2025
a61dbbb
revert: Remove outdated complexity counts
dangotbanned Jun 16, 2025
c0c142c
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jun 16, 2025
b2feb1e
chore: Remove more outdated
dangotbanned Jun 16, 2025
b50456d
refactor: Move functions into `PandasLikeGroupBy
dangotbanned Jun 16, 2025
12ae9af
fix: Use alias instead of function name
dangotbanned Jun 16, 2025
f24651d
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 16, 2025
b420085
refactor: Don't store two `PandasLikeDataFrame`
dangotbanned Jun 16, 2025
5965a48
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 16, 2025
3a905a6
fix(DRAFT): Slap on non `str` support
dangotbanned Jun 17, 2025
00b303a
Merge branch 'simp-pandas-group-by' of https://github.com/narwhals-de…
dangotbanned Jun 17, 2025
f9b0cc5
fix(typing): Resolve intermittent variance issue
dangotbanned Jun 17, 2025
732fdc9
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 17, 2025
eea8e64
fix: Don't use `methodcaller` w/ modin
dangotbanned Jun 17, 2025
d78d541
cov ignore
dangotbanned Jun 17, 2025
a2f4f48
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jun 17, 2025
243f6cf
test: Add (failing) case
dangotbanned Jun 17, 2025
80cfb1b
fix: Everything except `modin[pyarrow]`
dangotbanned Jun 17, 2025
8fe49c7
test: xfail modin, dask
dangotbanned Jun 17, 2025
2317ff4
test: Add failing `plotly` repro
dangotbanned Jun 19, 2025
07c093e
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 19, 2025
82c31ba
test: Rewrite as minimal repro
dangotbanned Jun 19, 2025
6fd3b4c
fix: Cast `string[pyarrow]` back to int
dangotbanned Jun 19, 2025
2e60863
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jun 19, 2025
508e604
refactor: Use `simple_select` instead of `select_columns_by_name`
dangotbanned Jun 19, 2025
87dc041
refactor: Shorten some paths
dangotbanned Jun 19, 2025
3c6eb58
🎨
dangotbanned Jun 19, 2025
b1f65bd
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 20, 2025
2f157df
test: Widen to `test_group_by_no_preserve_dtype`
dangotbanned Jun 20, 2025
46e5ae0
fix: Address all non-int dtypes
dangotbanned Jun 20, 2025
af04570
test: Skip `Decimal` for polars when unsupported
dangotbanned Jun 20, 2025
5a540ff
fix: Handle old pandas float
dangotbanned Jun 20, 2025
4944e38
refactor: Make `exclude` a property
dangotbanned Jun 20, 2025
c2df420
refactor: Move all state into `AggExpr`, docs
dangotbanned Jun 20, 2025
26539c5
revert: Remove unused caching
dangotbanned Jun 20, 2025
7bb0d0d
fix: Try higher min pandas
dangotbanned Jun 20, 2025
4628f2e
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 21, 2025
2683b58
refactor: Renaming, make `native_agg` a method
dangotbanned Jun 21, 2025
bff83c8
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 21, 2025
83c591e
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jun 24, 2025
e0984ae
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 24, 2025
c29c8fc
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 25, 2025
b194e10
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 25, 2025
4cc6543
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 27, 2025
58d044c
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 28, 2025
b59c774
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 28, 2025
f116ada
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 28, 2025
cf5285c
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jun 30, 2025
f5f2798
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jul 3, 2025
3065418
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jul 3, 2025
c8cbd78
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jul 5, 2025
de7347e
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jul 6, 2025
b7e7b37
refactor: Use `list.copy` on keys
dangotbanned Jul 8, 2025
da7ea98
perf: Collect `dtypes` outside of the loop
dangotbanned Jul 8, 2025
532d6b3
refactor: `_agg_complex` -> `apply_aggs`, `_apply_exprs` -> `_apply_e…
dangotbanned Jul 8, 2025
502bcdc
Merge remote-tracking branch 'camriddell/main' into simp-pandas-group-by
dangotbanned Jul 8, 2025
c52bf66
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jul 9, 2025
5fd4160
fix(typing): Bump stubs, doc new ignore `include_groups`
dangotbanned Jul 9, 2025
cfeac25
perf: Use `rename` instead of `with_columns`
dangotbanned Jul 9, 2025
24eb873
try `rename` with `copy=True`
dangotbanned Jul 9, 2025
46282e8
revert: try rename with copy=True
dangotbanned Jul 9, 2025
9fe1642
test: Add failing repro
dangotbanned Jul 10, 2025
9eb672e
fix(DRAFT): Are we passing yet? 🙏
dangotbanned Jul 10, 2025
53eab03
chore(typing): ignore `apply` overload
dangotbanned Jul 10, 2025
cc7a9a0
Merge remote-tracking branch 'upstream/main' into simp-pandas-group-by
dangotbanned Jul 10, 2025
44ba496
re-undo undoing ignore 😭
dangotbanned Jul 10, 2025
60461d9
Merge branch 'main' into simp-pandas-group-by
FBruzzesi Jul 11, 2025
91b5800
refactor: Switch back from `.agg(**named_aggs)` to `__getitem__`
dangotbanned Jul 11, 2025
c053971
Merge branch 'simp-pandas-group-by' of https://github.com/narwhals-de…
dangotbanned Jul 11, 2025
5899103
fix: `pandas` nightly boolean columns
dangotbanned Jul 11, 2025
13fdb47
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jul 12, 2025
e93044e
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jul 14, 2025
1672513
Merge branch 'main' into simp-pandas-group-by
dangotbanned Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading