Skip to content

Conversation

@MarcoGorelli
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@dangotbanned
Copy link
Member

I thought that plan was from_iterable and/or from_numpy?

At the very least, could we change the spelling to match where the term originated?

@MarcoGorelli
Copy link
Member Author

yeah just struggling to think of a good name

if from_iterable doesn't come with any unexpected implications (which I can't think of), that's probably fine

@MarcoGorelli MarcoGorelli changed the title enh: deprecate nw.new_series in favour of Series.from_arraylike enh: deprecate nw.new_series in favour of Series.from_iterable Jun 5, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review June 5, 2025 11:10
@dangotbanned dangotbanned mentioned this pull request Jul 26, 2025
6 tasks
dangotbanned added a commit that referenced this pull request Jul 26, 2025
- Part of #2116
- Based on #2887
- Related #2642
@dangotbanned dangotbanned mentioned this pull request Jul 26, 2025
17 tasks
@dangotbanned
Copy link
Member

Hey @MarcoGorelli πŸ‘‹

If you'd like, I could probably tick this one off of (#2116) pretty quickly by adapting (#2893)?

I think the deprecation was the open question here - but I haven't been adding those in the other PRs

@dangotbanned dangotbanned linked an issue Aug 2, 2025 that may be closed by this pull request
@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Aug 3, 2025

sure, closing this one as stale / not planned, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Series.from_iterable

2 participants