chore: Simplify to_py_scalar
#2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One item in (#2492)
To remove `C901` we need to go from `13` -> `10` statements
dangotbanned
commented
May 6, 2025
dangotbanned
commented
May 6, 2025
dangotbanned
commented
May 6, 2025
narwhals/translate.py
Outdated
Comment on lines
841
to
842
| f"Expected object convertible to a scalar, found {type(scalar_like)}.\n" | ||
| f"{scalar_like!r}" |
Member
Author
There was a problem hiding this comment.
I can revert this, but I don't think that message makes any sense 😄
import narwhals as nw
>>> nw.to_py_scalar([1,2,3])
ValueError: Expected object convertible to a scalar, found <class 'list'>. Please report a bug to https://github.com/narwhals-dev/narwhals/issuesFinally got rid of (`C901`)!\Nhttps://github.com//pull/2503#discussion_r2075637164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below