Skip to content

patch: Avoid pyspark no partition for window ops warning #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FBruzzesi merged 1 commit into from
Apr 24, 2025
Merged

patch: Avoid pyspark no partition for window ops warning #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions narwhals/_spark_like/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,17 +577,15 @@ def _n_unique(_input: Column) -> Column:

return self._with_callable(_n_unique)

def over(
self,
partition_by: Sequence[str],
order_by: Sequence[str] | None,
) -> Self:
def over(self, partition_by: Sequence[str], order_by: Sequence[str] | None) -> Self:
if (window_function := self._window_function) is not None:
assert order_by is not None # noqa: S101

def func(df: SparkLikeLazyFrame) -> list[Column]:
return [
window_function(WindowInputs(expr, partition_by, order_by))
window_function(
WindowInputs(expr, partition_by or [self._F.lit(1)], order_by)
)
for expr in self._call(df)
]
else:
Expand Down
2 changes: 1 addition & 1 deletion narwhals/_spark_like/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class WindowInputs:
def __init__(
self,
expr: Column,
partition_by: Sequence[str],
partition_by: Sequence[str] | Sequence[Column],
order_by: Sequence[str],
) -> None:
self.expr = expr
Expand Down
Loading