chore(typing): fix/ignore utils, tpch warnings

[dangotbanned]

What type of PR is this? (check all applicable)

• 💾 Refactor
• ✨ Feature
• 🐛 Bug Fix
• 🔧 Optimization
• 📝 Documentation
• ✅ Test
• 🐳 Other

Related issues

• Related issue feat: unify exception for nested over statements, nested aggregations, filtrations on aggregations, document expression metadata better #2351 (comment)

Checklist

• Code follows style guide (ruff)
• Tests added
• Documented the changes

If you have comments or can explain your changes, please do so below

[dangotbanned]

Hmmm, not sure what's going on in ci 🤔
https://results.pre-commit.ci/run/github/760058710/1745426178.-zxDJo8RTMqkvd3uYQp_eg

This is working for me locally:

from __future__ import annotations

from typing import Any
from typing import Iterator

import narwhals as nw


def _is_public_method_or_property(obj: Any) -> bool:
    return (
        (inspect.isfunction(obj) or isinstance(obj, property))
        and not obj.__name__[0].isupper()
        and obj.__name__[0] != "_"
    )


def iter_api_reference_names(tp: type[Any]) -> Iterator[str]:
    for name, _ in inspect.getmembers(tp, _is_public_method_or_property):
        yield name


it = iter_api_reference_names(nw.DataFrame)
>>> list(it)

Output

['clone',
 'collect_schema',
 'columns',
 'drop',
 'drop_nulls',
 'estimated_size',
 'explode',
 'filter',
 'gather_every',
 'get_column',
 'group_by',
 'head',
 'implementation',
 'is_duplicated',
 'is_empty',
 'is_unique',
 'item',
 'iter_columns',
 'iter_rows',
 'join',
 'join_asof',
 'lazy',
 'null_count',
 'pipe',
 'pivot',
 'rename',
 'row',
 'rows',
 'sample',
 'schema',
 'select',
 'shape',
 'sort',
 'tail',
 'to_arrow',
 'to_dict',
 'to_native',
 'to_numpy',
 'to_pandas',
 'to_polars',
 'unique',
 'unpivot',
 'with_columns',
 'with_row_index',
 'write_csv',
 'write_parquet']

Update 1

Ah there's the issue https://github.com/python/typeshed/blob/ae57d69c9354147bcf7086d6db47af8f8c82bf7b/stdlib/builtins.pyi#L1266-L1272

class property:
    fget: Callable[[Any], Any] | None
    fset: Callable[[Any, Any], None] | None
    fdel: Callable[[Any], None] | None
    __isabstractmethod__: bool
    if sys.version_info >= (3, 13):
        __name__: str

Update 2

Fixed in (86dda9b) 🥳

[MarcoGorelli]

thanks - should we also run mypy on these folders in ci if the types are fixed?

[MarcoGorelli]

what's the issue with importing FrameT from narwhals._typing?

[dangotbanned]

@MarcoGorelli it is the same problem from

• (b28da50)
• (feat: Allow expressions as group_by keys #2325 (comment))
• (feat: Allow expressions as group_by keys #2325 (comment))
• (https://github.com/narwhals-dev/narwhals/actions/runs/14551438598/job/40823080572?pr=2325)

We're seeing it a lot more in the tpch tests since they do multiple transformations on FrameT

[dangotbanned]

thanks - should we also run mypy on these folders in ci if the types are fixed?

Thanks @MarcoGorelli

I suppose we could do!
I'm not sure if mypy will pass, my goal was really just to be able to open these files in VSCode and not be bombarded by warnings 😄

Generally, I think it would be a positive step forwards to enable ruff, mypy, pyright on all of these directories.
If there are particular rules/codes that are frustrating - we have options to disable things in a granular way 🙂

[MarcoGorelli]

thanks!

[MarcoGorelli]

separately, this makes me wonder if we need to redefine FrameT 🤔