refactor: Simplify (Arrow|PandasLike)Namespace.concat#2381
Merged
dangotbanned merged 10 commits intomainfrom Apr 14, 2025
Merged
refactor: Simplify (Arrow|PandasLike)Namespace.concat#2381dangotbanned merged 10 commits intomainfrom
(Arrow|PandasLike)Namespace.concat#2381dangotbanned merged 10 commits intomainfrom
Conversation
Has no coverage, would be caught later with a nicer error anyway w/ https://github.com/narwhals-dev/narwhals/blob/41871f775589359c563150526d03935449709d7d/narwhals/utils.py#L1466-L1475
One became a type, the other is moving to github
dangotbanned
commented
Apr 13, 2025
| def _concat_horizontal( | ||
| self, dfs: Sequence[NativeFrameT | Any], / | ||
| ) -> NativeFrameT: ... | ||
| def _concat_vertical(self, dfs: Sequence[NativeFrameT], /) -> NativeFrameT: ... |
Member
Author
There was a problem hiding this comment.
Note
We could pretty easily support how="vertical" for NativeSeriesT
That is the only ConcatMethod that polars allows for Series
pyarrowwould usepa.concat_arrays(pandas|polars)just use theirconcatfunction again
I'm not in a rush to add it, but this PR certainly makes that next step quite simple 😅
dangotbanned
changed the title
ArrowNamespace.concat(Arrow|PandasLike)Namespace.concat
FBruzzesi
approved these changes
Apr 14, 2025
Member
FBruzzesi
left a comment
FBruzzesi
left a comment
There was a problem hiding this comment.
Thanks @dangotbanned - it certainly simplifies the logic and set it up for mooore (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Iterable[Table]inconcat_tableszen-xu/pyarrow-stubs#203PandasLikeNamespace.concat#2368Checklist
If you have comments or can explain your changes, please do so below