Skip to content

chore: prepare tests for v2#2380

Merged
MarcoGorelli merged 31 commits intonarwhals-dev:mainfrom
MarcoGorelli:prepare-for-v2
Apr 12, 2025
Merged

chore: prepare tests for v2#2380
MarcoGorelli merged 31 commits intonarwhals-dev:mainfrom
MarcoGorelli:prepare-for-v2

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Apr 12, 2025

Summary:

  • use import narwhals as nw for most tests
  • make a separate v1_test.py test file for methods which we override in v1

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 12, 2025 18:56
@MarcoGorelli
Copy link
Member Author

193 files changed 🙈

i may have to invoke "yo trust me i got dis" permissions here

@MarcoGorelli MarcoGorelli merged commit 52355ea into narwhals-dev:main Apr 12, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant