chore: Use _compliant.typing aliases in more places#2336
Merged
MarcoGorelli merged 6 commits intomainfrom Apr 5, 2025
Merged
Conversation
dangotbanned
added
documentation
dangotbanned
commented
Apr 4, 2025
narwhals/_compliant/typing.py
Outdated
Comment on lines
128
to
129
| EvalNames: TypeAlias = Callable[[CompliantFrameT], Sequence[str]] | ||
| """**NEEDS DOC**""" |
Member
Author
There was a problem hiding this comment.
@MarcoGorelli I was hoping you might have an idea on how to describe this one?
Most often it is being used for CompliantExpr._evaluate_output_names
narwhals/narwhals/_arrow/expr.py
Lines 32 to 42 in edf283e
Member
There was a problem hiding this comment.
it's used to resolve the output names which would occur before any aliases take place
Member
Author
There was a problem hiding this comment.
Thanks @MarcoGorelli, I've adapted that into (bb326ec)
Happy for anyone to tweak these descriptions 🙌
dangotbanned
changed the title
_compliant.typing in more places_compliant.typing aliases in more places
MarcoGorelli
approved these changes
Apr 5, 2025
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
love this, thanks @dangotbanned !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
selectorsaway fromProtocol38#2326 (comment)Checklist
If you have comments or can explain your changes, please do so below
Follow-up to (#2326 (comment))