-
Notifications
You must be signed in to change notification settings - Fork 179
chore: Add Compliant*.from_native
#2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
21b936e
feat(typing): Add `FromNative` protocol
dangotbanned 91870db
chore(typing): Add `FromNative` to `CompliantSeries`
dangotbanned 4f1578f
feat: Implement for `(Arrow|PandasLike)Series`
dangotbanned f278e67
feat: Implement for `PolarsSeries`
dangotbanned 9c55759
chore: `ArrowSeries` coverage
dangotbanned 8aabde8
chore: `PandasLikeSeries` partial coverage
dangotbanned f80c693
Merge remote-tracking branch 'upstream/main' into compliant-from-native
dangotbanned edf4c8c
ignore coverage for now ...
dangotbanned 9e21718
feat(typing): Add `CompliantDataFrame.from_native`
dangotbanned 0118eb0
feat: Implement for `ArrowDataFrame`
dangotbanned 4701561
feat: Implement for `PandasLikeDataFrame`
dangotbanned 2d9da37
feat: Implement for `PolarsDataFrame`
dangotbanned 44a36f7
refactor: Found one more
dangotbanned ec187d5
chore(typing): Fix missing `SQLExpression` ignore
dangotbanned 766b67a
feat: Implement `EagerNamespace.from_native`
dangotbanned 2de6b56
feat: Add `Polars(Namespace|LazyFrame).from_native`
dangotbanned c4e8f56
chore: Ignore coverage `PandasLikeDataFrame._is_native`
dangotbanned ba7506a
feat: Add all `CompliantLazyFrame.from_native`
dangotbanned fc9506a
feat: Add `LazyNamespace.from_native`
dangotbanned 6ed3c9d
refactor: Get some lazy coverage
dangotbanned 9396bbc
refactor: More `polars` coverage
dangotbanned 43cf204
Merge branch 'main' into compliant-from-native
dangotbanned d628a9f
refactor: reuse `is_spark_like_dataframe`
dangotbanned e58419a
Merge branch 'compliant-from-native' of https://github.com/narwhals-dβ¦
dangotbanned de9483e
Merge branch 'main' into compliant-from-native
dangotbanned 3b4feb2
Merge remote-tracking branch 'upstream/main' into compliant-from-native
dangotbanned 4109c99
Merge branch 'main' into compliant-from-native
dangotbanned cdd1913
Merge branch 'main' into compliant-from-native
dangotbanned 4ab34e0
Merge branch 'main' into compliant-from-native
dangotbanned 4c08fff
Update narwhals/_compliant/namespace.py
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been thinking about combining these as one protocol.
_StoreNativemight still be useful on its own, but something like this could be nice:Not super important though π