Merged
Conversation
dangotbanned
commented
Mar 29, 2025
Comment on lines
+93
to
+97
| if self._backend_version >= (1, 18): | ||
| native = self.native.is_nan() | ||
| else: # pragma: no cover | ||
| native = pl.when(self.native.is_not_null()).then(self.native.is_nan()) | ||
| return self._with_native(native) |
Member
Author
There was a problem hiding this comment.
I flipped the order to avoid a warning from mypy.
- The second branch is
pl.Theninstead ofpl.Expr - That's fine this way, because it is a subclass of
pl.Expr
Member
Author
There was a problem hiding this comment.
More generally though, using >= is more common outside of narwhals.
Although I'm not sure how to rewrite these rules to work that way - so no biggie 🙂
Lines 255 to 266 in 5550ad8
MarcoGorelli
approved these changes
Mar 29, 2025
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
very nice, thanks @dangotbanned !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
._with_*for internal API methods #2305Compliant*protocols #2230Checklist
If you have comments or can explain your changes, please do so below
Missed during the linked PRs/issues, but noticed in (#2312)