chore: Add CompliantExpr._with_metadata

[MarcoGorelli]

This avoid the need to have kind as an argument in over, and also gives us a way to use ExprMetadata at the compliant level in other places (e.g. group_by.agg), so we can get rid of tracking function_name at the compliant level

What type of PR is this? (check all applicable)

• 💾 Refactor
• ✨ Feature
• 🐛 Bug Fix
• 🔧 Optimization
• 📝 Documentation
• ✅ Test
• 🐳 Other

Related issues

• Related issue #<issue number>
• Closes #<issue number>

Checklist

• Code follows style guide (ruff)
• Tests added
• Documented the changes

If you have comments or can explain your changes, please do so below

[MarcoGorelli]

@dangotbanned I suspect (and have good reason to believe) that you can probably think of a better way to do this, in which case, feel free to add a commit to do so 🙏

[dangotbanned]

@dangotbanned I suspect (and have good reason to believe) that you can probably think of a better way to do this, in which case, feel free to add a commit to do so 🙏

Thanks for the complimentary ping @MarcoGorelli 😍

I'll take a look later today

[dangotbanned]

I'm just looking from my phone, apologies for the stray comment.

Would it make sense to add a with_metadata implementation for EagerExpr and/or LazyExpr?

You can always override it if there's something unique for a given backend (e.g. window_function).
I'd think there'd be some potential for reuse on that front

[dangotbanned]

Apologies for all the questions before doing any commits 😅

Wanna make sure any changes I make are preserving your intent

[dangotbanned]

LGTM, thanks @MarcoGorelli

All 3 of the LazyExpr constructors differ - so I only did the EagerExpr part of (#2262 (comment))

Will leave it to you for merging/making further tweaks 🙌

[MarcoGorelli]

awesome, thanks @dangotbanned !