chore(typing): add missing _FullContext to CompliantDataFrame#2251
Merged
MarcoGorelli merged 3 commits intomainfrom Mar 20, 2025
Merged
chore(typing): add missing _FullContext to CompliantDataFrame#2251MarcoGorelli merged 3 commits intomainfrom
_FullContext to CompliantDataFrame#2251MarcoGorelli merged 3 commits intomainfrom
Conversation
- Only spotted while trying out `CompliantGroupBy` - `CompliantLazyFrame` already has these attributes
This was referenced Mar 19, 2025
dangotbanned
commented
Mar 20, 2025
Comment on lines
+53
to
+55
| _implementation: Implementation | ||
| _backend_version: tuple[int, ...] | ||
| _version: Version |
Member
Author
There was a problem hiding this comment.
I was pretty surprised that I didn't need to change anything outside of the protocol
Looks like everyone was already compliant 😄
dangotbanned
added a commit
that referenced
this pull request
Mar 20, 2025
MarcoGorelli
pushed a commit
that referenced
this pull request
Mar 20, 2025
* feat(DRAFT): Add `CompliantGroupBy` Based on (#2184 (comment)) * fix: `3.8` compat Needed for `__init__` support * chore: export to `_compliant` * refactor: Implement `ArrowGroupBy` * fix(typing): Get an agreement on variance - Dropped `native` as it got too complex - I've done this fake `Any` thing to make `mypy` understand in multiple places * refactor: Implement `PandasLikeGroupBy`? - Having a hard time working out what is going on here - All I've changed is what the refs are named * refactor: Implement `DaskLazyGroupBy` Much happier with this than the `pandas` one * chore(typing): Utilize (#2251) Fixes https://github.com/narwhals-dev/narwhals/actions/runs/13968615945/job/39104706209?pr=2252 * refactor: `CompliantGroupBy._remap_expr_name` - Shorted in each backend - Added docs - Accounts for `dask` deviation from `str` * refactor: `CompliantGroupBy._leaf_name` - More performant to compile a single pattern and reuse everywhere - Gives a name to a common op - Backend code is shorter * refactor: `CompliantGroupBy._is_simple` Keeps this part of `pandas` in sync, despite it doing some extra name stuff * fix: pre `3.13` protocol support https://results.pre-commit.ci/run/github/760058710/1742478308._GAah8QXT2i9H9TbtcMHwQ * refactor: Move most of `CompliantGroupBy` -> `DepthTrackingGroupBy` - `_duckdb` and `_spark_like` don't need these parts (only `_dask` does) - Also avoids needing a `TypeVar` default, which caused some issues in https://github.com/narwhals-dev/narwhals/actions/runs/13970848097/job/39111959826?pr=2252 * refactor(DRAFT): Start simplifying, aligning lazy group bys - These two are almost identical - Trying to reduce them as much as possible, before moving the common parts to `nw._compliant.LazyGroupBy` * help `mypy` https://github.com/narwhals-dev/narwhals/actions/runs/13972033263/job/39116058196?pr=2252 * refactor: Adds `LazyGroupBy` - Greatly simplifies what each backend needs to implement - Avoids creating and combining intermediate lists - Avoids performing a `not in exclude` check, where `exclude` is empty - Identified and documented a new common method `CompliantExpr._is_multi_output_agg` * feat(typing): `Polars*GroupBy` and `Compliant*Frame` - Will need to make (inavriant) `CompliantExprT` to type the second part correctly - Believe that is also causing this weird error ``` Argument of type "CompliantExprT_contra@CompliantDataFrame" cannot be assigned to parameter "exprs" of type "CompliantExprT_contra@CompliantDataFrame" in function "select" Type "CompliantExprT_contra@CompliantDataFrame" is not assignable to type "CompliantExprT_contra@CompliantDataFrame" Pylance(reportArgumentType) ``` * chore: Rename pattern, remove temp doc * Long variable names < types & docs * refactor: listcomp < genexpr * chore(typing): Temp ignore for false positive * avoid unused import * refactor: Use `Implementation.is_pandas`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
CompliantDataFrame#2223CompliantLazyFrame#2232Checklist
If you have comments or can explain your changes, please do so below
CompliantGroupBy#2252)CompliantLazyFramealready has these attributes