feat!: remove maintain_order from LazyFrame.unique, as it was never supported#2247
Merged
MarcoGorelli merged 2 commits intonarwhals-dev:mainfrom Mar 19, 2025
Merged
Conversation
MarcoGorelli
pushed a commit
that referenced
this pull request
Mar 19, 2025
* chore(typing): Mostly finish `CompliantLazyFrame` * fix: add missing `CompliantDataFrame.explode` * feat(typing): Adds `not_implemented.deprecated` Only way I've come up with to preserve the deprecation message * chore(typing): Finish `PolarsLazyFrame` * chore(typing): Finish `SparkLikeLazyFrame` * chore(typing): Finish `DaskLazyFrame` * chore(typing): Finish `DuckDBLazyFrame` * fix(typing): `PandasLikeDataFrame.explode` * chore(typing): Mark `.lazy` return as `Incomplete` I can't work out what is the desired behavior * chore(typing): Fill `Incomplete` for `*Expr` * revert: remove `.to_(arrow|pandas)` #2232 (comment) * fix(DRAFT): Expose `CompliantLazyFrame.native` - Will need something similar with `DataFrame` - Aiming to solve #2239 (comment) * fix: remove default in `CompliantLazyFrame.lazy` ```py narwhals/_compliant/dataframe.py:262: error: Definition of "lazy" in base class "CompliantDataFrame" is incompatible with definition in base class "CompliantLazyFrame" [misc] class EagerDataFrame( ^ ``` * fix(typing): Align `unique` sigantures 3x of these: ```py error: Signature of "unique" incompatible with supertype "CompliantLazyFrame" [override] ``` Even though `maintain_order` is unused - `EagerDataFrame` (and subclasses) require the same signature * fix: coverage for `PolarsLazyFrame.native` https://github.com/narwhals-dev/narwhals/actions/runs/13929256423/job/38981936344 * fix(typing): Add missing `_change_version` method > error: Cannot access attribute "_change_version" for class "CompliantLazyFrame[Any, FrameT@_stableify]" * chore(typing): Mark intended annotation, that isn't valid yet `mypy` expands to an invalid type > "CompliantLazyFrame[Any, NativeFrame]" of "Any | CompliantLazyFrame[Any, NativeFrame] | CompliantLazyFrame[Any, DataFrame[Any]] | CompliantLazyFrame[Any, LazyFrame[Any]] | CompliantLazyFrame[Any, DataFrameLike]" * revert: remove `CompliantLazyFrame.lazy` #2232 (comment) * lol `maintain_order` default one side only 😅 Resolves #2232 (comment) * revert: don't widen `keep` for lazy * make `keep` a keyword again conflict from (#2247)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this affects anyone, we could backport
maintain_orderas a no-op tostable.v1What type of PR is this? (check all applicable)
Related issues
CompliantLazyFrame#2232 (comment)CompliantLazyFrame#2232 (comment)Checklist
If you have comments or can explain your changes, please do so below