-
Notifications
You must be signed in to change notification settings - Fork 180
feat: Adds nw.exclude
#2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Adds nw.exclude
#2122
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
95fc0d0
Adds exclude
thomasjpfan d733bb2
Address comments
thomasjpfan 07deb3a
Use frozenset
thomasjpfan 8fa7acd
refactor: share `frozenset`
dangotbanned 5c51214
Use better name for namespace functions
thomasjpfan 287e095
Merge branch 'main' into exclude
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| import pytest | ||
|
|
||
| import narwhals.stable.v1 as nw | ||
| from tests.utils import assert_equal_data | ||
|
|
||
| if TYPE_CHECKING: | ||
| from tests.utils import Constructor | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("exclude_selector", "expected_cols"), | ||
| [ | ||
| (nw.exclude("a"), ["b", "z"]), | ||
| (nw.exclude("b", "z"), ["a"]), | ||
| (nw.exclude(["a"]), ["b", "z"]), | ||
| (nw.exclude(["b", "z"]), ["a"]), | ||
| ], | ||
| ) | ||
| def test_exclude( | ||
| constructor: Constructor, exclude_selector: nw.Expr, expected_cols: list[str] | ||
| ) -> None: | ||
| data = {"a": [1, 3, 2], "b": [4, 4, 6], "z": [7.0, 8.0, 9.0]} | ||
|
|
||
| df = nw.from_native(constructor(data)) | ||
| result = df.select(exclude_selector) | ||
|
|
||
| expected = {col: data[col] for col in expected_cols} | ||
| assert_equal_data(result, expected) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could tweak
ArrowExpr.from_column_namesand use it here π€ It might be a refactor follow upThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor would be to accept able callable that returns the names.
Then
excludeandcolgets refactored to:I did not want to increase the scope of this PR by changing the signature of
from_column_namesand changingcol. I'm okay with doing a quick follow up.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thomasjpfan
Yes I think in the long term that's desirable and we should aim for that
Happy to keep it as follow up