Skip to content

refactor: deduplicate *.selectors#2057

Merged
MarcoGorelli merged 7 commits intomainfrom
selectors-dedup-1
Feb 20, 2025
Merged

refactor: deduplicate *.selectors#2057
MarcoGorelli merged 7 commits intomainfrom
selectors-dedup-1

Conversation

@dangotbanned
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

There's still a lot more than could be shared between backends.

Thought I'd check in to see if ideas like this are desirable

@dangotbanned
Copy link
Member Author

Why is validoopsie importing a symbol I literally just declared? 😕
Its within a TYPE_CHECKING block and _private

https://github.com/narwhals-dev/narwhals/actions/runs/13441335609/job/37556249471?pr=2057#step:9:92

ImportError - cannot import name '_FullContext' from 'narwhals.utils' (/home/runner/work/narwhals/narwhals/narwhals/utils.py)

@dangotbanned dangotbanned marked this pull request as ready for review February 20, 2025 17:49
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @dangotbanned !

@MarcoGorelli MarcoGorelli merged commit c18c145 into main Feb 20, 2025
28 checks passed
@MarcoGorelli MarcoGorelli deleted the selectors-dedup-1 branch February 20, 2025 18:03
dangotbanned added a commit that referenced this pull request Feb 22, 2025
Only added in #2057, but not needed now this is a method
dangotbanned added a commit that referenced this pull request Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants