refactor(typing): make _evaluate_output_names generic

[dangotbanned]

What type of PR is this? (check all applicable)

• 💾 Refactor
• ✨ Feature
• 🐛 Bug Fix
• 🔧 Optimization
• 📝 Documentation
• ✅ Test
• 🐳 Other

Related issues

• ci(typing): add pyright to ci #2035 (comment)
• refactor: Generic CompliantSelector #2064

Checklist

• Code follows style guide (ruff)
• Tests added
• Documented the changes

If you have comments or can explain your changes, please do so below

Follow up to (#2035), with a change that solves the last 10 errors.

Important

The commit history wasn't clean
PR branched b26c94c (#2035)

As mentioned in (#2035 (comment)), there are some similar changes in reuse-sub-protocols

That branch will need some tweaks after this, but it will also benefit - as it currently types this as Any to avoid the same error:

narwhals/narwhals/_protocols.py

Lines 53 to 66 in 0abb3d3

	_evaluate_output_names: Any
	_alias_output_names: Any
	_implementation: Implementation
	_backend_version: tuple[int, ...]
	_version: Version
	_kwargs: dict[str, Any]
	def __init__(
	self: Self,
	call: Callable[[CompliantDataFrameT_co], Sequence[ReuseSeriesT]],
	*,
	depth: int,
	function_name: str,
	evaluate_output_names: Callable[[CompliantDataFrameT_co], Sequence[str]],

---

In (#2064), I've been using the aliases (EvalSeries, EvalNames) which I think give a huge boost to readability:

narwhals/narwhals/_selectors.py

Lines 42 to 51 in e6f2d07

	class CompliantSeriesWithDType(CompliantSeries, Protocol):
	@property
	def dtype(self) -> DType: ...
	SeriesT = TypeVar("SeriesT", bound="CompliantSeriesWithDType")
	FrameT = TypeVar("FrameT", bound="CompliantDataFrame | CompliantLazyFrame")
	SelectorOrExpr: TypeAlias = "CompliantSelector[FrameT, SeriesT] | CompliantExpr[SeriesT]"
	EvalSeries: TypeAlias = Callable[[FrameT], Sequence[SeriesT]]
	EvalNames: TypeAlias = Callable[[FrameT], Sequence[str]]

vs main:

narwhals/narwhals/typing.py

Lines 80 to 90 in b03f716

	class CompliantExpr(Protocol, Generic[CompliantSeriesT_co]):
	_implementation: Implementation
	_backend_version: tuple[int, ...]
	_version: Version
	_evaluate_output_names: Callable[
	[CompliantDataFrame | CompliantLazyFrame], Sequence[str]
	]
	_alias_output_names: Callable[[Sequence[str]], Sequence[str]] | None
	_depth: int
	_function_name: str

[dangotbanned]

I was playing around with fixing the ignores - noticed this was unused

[MarcoGorelli]

thanks @dangotbanned !

[dangotbanned]

thanks @dangotbanned !

Thanks @MarcoGorelli!

I botched the git history in at least 3 different ways on this PR 😅
Very happy its off my hands now