-
Notifications
You must be signed in to change notification settings - Fork 180
feat: Add backend argument to lazy
#1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
69e5ccc
cfb4904
89b0e47
835feec
9499383
0c339ff
b209c6c
c74778a
a379167
0c70307
cfca1a0
6444a7e
c92c5a0
b352f71
0292363
24c4ebf
999f3ed
66fe6a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -142,7 +142,14 @@ def drop(self: Self, columns: list[str], strict: bool) -> Self: # noqa: FBT001 | |||||
| selection = (col for col in self.columns if col not in columns_to_drop) | ||||||
| return self._from_native_frame(self._native_frame.select(*selection)) | ||||||
|
|
||||||
| def lazy(self: Self) -> Self: | ||||||
| def lazy(self: Self, *, backend: Implementation | None = None) -> Self: | ||||||
| # The `backend`` argument has no effect but we keep it here for | ||||||
| # backwards compatibility because in `narwhals.stable.v1` | ||||||
| # function `.from_native()` will return a DataFrame for DuckDB. | ||||||
|
|
||||||
| if backend is not None: # pragma: no cover | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think duckdb should be allowed?
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i don't think it needs to be - if this path only exists for v1 backwards-compatibility, then #1895 (comment) is something somebody could have written, but they wouldn't have passed a backend, so raising for |
||||||
| msg = "`backend` argument is not supported for DuckDB" | ||||||
| raise ValueError(msg) | ||||||
| return self | ||||||
|
|
||||||
| def with_columns( | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.