Skip to content

chore: rename series and expr to _compliant for Arrow, Polars, and Dask #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2024
Merged

chore: rename series and expr to _compliant for Arrow, Polars, and Dask #1537

merged 1 commit into from
Dec 8, 2024

Conversation

@olp-cs
Copy link
Contributor

@olp-cs olp-cs commented Dec 8, 2024

What type of PR is this? (check all applicable)

  • 💾 Refactor

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

Details

  • Renamed _arrow_series to _compliant_series in ArrowSeries classes (ArrowSeriesCatNamespace, ArrowSeriesDateTimeNamespace, ArrowSeriesStringNamespace)

  • Renamed _expr to _compliant_expr in ArrowExpr classes (ArrowExprCatNamespace, ArrowExprDateTimeNamespace, ArrowExprStringNamespace, ArrowExprNameNamespace)

  • Renamed _series to _compliant_series in PolarsSeries classes (PolarsSeriesCatNamespace, PolarsSeriesDateTimeNamespace, PolarsSeriesStringNamespace)

  • Renamed _expr to _compliant_expr in PolarsExp classes (PolarsExprCatNamespace, PolarsExprDateTimeNamespace, PolarsExprStringNamespace, PolarsExprNameNamespace)

  • Renamed _expr to _compliant_expr in several DaskExpr classes (DaskExprDateTimeNamespace, DaskExprStringNamespace, DaskExprNameNamespace)

⚠️ Note: I didn't find a class named DaskExprCatNamespace mentioned in #1499

MarcoGorelli
MarcoGorelli approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @olp-cs !

@MarcoGorelli MarcoGorelli merged commit 9742ee5 into narwhals-dev:main Dec 8, 2024
24 checks passed
@olp-cs olp-cs deleted the 1499_compliant branch December 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees

No one assigned

Labels

internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olp-cs @MarcoGorelli