feat: add Series|Expr.is_finite method
#1341
Open
+186
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Nov 12, 2024
FBruzzesi
commented
Nov 12, 2024
Comment on lines
+768
to
+770
| return self._from_native_series( | ||
| np.isfinite(self._native_series) & ~self._native_series.isna() | ||
| ) |
There was a problem hiding this comment.
Here is a opinionated choice that na is not finite
There was a problem hiding this comment.
🤔 no sure, wouldn't we want to preserve null values?
There was a problem hiding this comment.
Behavior is different for different pandas backend dtype. Let me come back with an example
There was a problem hiding this comment.
hmmm actually, for classical pandas types, we wouldn't have the option of returning a nullable boolean (if we want to preserve the dtype backend)
🤔 gonna think about this a little longer
There was a problem hiding this comment.
These would be the output:
data = [float("nan"), float("inf"), 2.0, None]
s = pd.Series(data)
np.isfinite(s)
0 False
1 False
2 True
3 False
dtype: boolnp.isfinite(s.convert_dtypes(dtype_backend="numpy_nullable"))
0 <NA>
1 False
2 True
3 <NA>
dtype: booleannp.isfinite(s.convert_dtypes(dtype_backend="pyarrow"))
0 False
1 False
2 True
3 False
dtype: boolWhile for polars:
pl.Series(data).is_finite()
shape: (4,)
Series: '' [bool]
[
false
false
true
null
]
EdAbati
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Series|Expr.is_finite#1297Checklist
If you have comments or can explain your changes, please do so below.
As mentioned in the issue itself, pandas and dask treat nan's and null's as same. Actually, even worse, for non nullable backend,
np.isfinitereturns False and for nullable-backends will return<NA>. I made the opinionated choice to be consistent across different pandas backends and always return False for nulls and nans. I hope the warning in the docstring is enough