add more powerful versions of execute, select and selectFirst #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myazinn
force-pushed
the
add_more_powerful_versions_of_execute_select_selectFirst
branch
from
1fdd442
to
a360f7d
Compare
myazinn
force-pushed
the
add_more_powerful_versions_of_execute_select_selectFirst
branch
from
a360f7d
to
ee0d19a
Compare
myazinn
commented
Sep 25, 2022
| final def prepare[V <: HList, R](query: ParameterizedQuery[V, R]): Task[Query[R]] = | ||
| prepare(query.template).map(_.applyProduct(query.values)) | ||
|
|
||
| final def execute[V <: HList, R](query: ParameterizedQuery[V, R]): Task[Boolean] = |
There was a problem hiding this comment.
Inconsistent return type with def execute(stmt: Statement[_]): Task[AsyncResultSet] method, but consistent with Query#execute one
narma
previously approved these changes
Sep 25, 2022
myazinn
force-pushed
the
add_more_powerful_versions_of_execute_select_selectFirst
branch
from
ee0d19a
to
d469c08
Compare
myazinn
changed the title
myazinn
force-pushed
the
add_more_powerful_versions_of_execute_select_selectFirst
branch
from
d469c08
to
4f26785
Compare
myazinn
force-pushed
the
add_more_powerful_versions_of_execute_select_selectFirst
branch
from
4f26785
to
df86187
Compare
narma
approved these changes
Sep 26, 2022
narma
deleted the
add_more_powerful_versions_of_execute_select_selectFirst
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, providing an environment sometimes can cause performance degradations and does not comply ZIO idiomatic application structure.
This MR adds new more powerful methods to
Sessionwhich allow running interpolated queries directly. Note thatcqltmethods are unsupported for now.