fix(web): chrome z-index above pixels + monochrome SVG playback icons#101
Merged
Conversation
DataPixel renders at zIndex 1000 inside the canvas wrapper, but the canvas pane has overflow: visible — so a carrot positioned near the pane's edge could paint over the chrome (top header, left FLOWS sidebar, right INSPECT panel, bookmark tabs). Pin all four to position: relative + zIndex: 1001 so they always sit above the pixels regardless of where the carrot is in mid-flight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR raises header, sidebar, and data inspection panel stacking to ChangesZ-index Stacking Context Updates & Playback UI
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Emoji glyphs (⏮ ⏪ ▶ ⏸ ⏩) get rendered in the platform's color emoji font on most systems, so the playback buttons showed Apple-blue or Win11-pink instead of picking up the green accent the rest of the chrome uses. Restart was using the skip-back glyph, which reads as "jump to first step" rather than "start over." Replace all five with sharp 16px-viewBox SVGs that use currentColor: - Restart → counter-clockwise circular arrow with an arrowhead tail, a real restart affordance. - Prev/Next → double-triangle skip glyphs. - Play/Pause → solid right-triangle / two vertical bars. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
naorsabag
added a commit
that referenced
this pull request
May 10, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataPixel renders at `zIndex: 1000` inside the canvas wrapper, but the canvas pane has `overflow: visible` — so a carrot positioned near the pane's edge could visually paint over the top header, the FLOWS sidebar, the INSPECT panel, or the bookmark tabs.
Pinned all four chrome elements to `position: relative` + `zIndex: 1001`:
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
New Features