Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundtouchjs support for pitch & tempo #148

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

naomiaro
Copy link
Owner

@naomiaro naomiaro changed the title chore: update webpack Soundtouchjs support for pitch & tempo Apr 27, 2021
@sanbaideng
Copy link

speed up is a good feature,thanks,

@naomiaro naomiaro merged commit 0cc4b63 into master Jul 27, 2021
@p-himik
Copy link
Contributor

p-himik commented Apr 27, 2022

@naomiaro If I understand correctly, the commit has been completely reverted. Was there something wrong with soundtouchjs that made its use unfeasible?

@naomiaro
Copy link
Owner Author

@p-himik It's limited to work with only one track that I saw at the moment.

@p-himik
Copy link
Contributor

p-himik commented Apr 27, 2022

Oh... but at least it sounds like we can have a pitch shifter per track with all pitch shifters not being a part of the API and being controlled in a centralized manner from Playlist. Would you consider a PR like that?

@naomiaro
Copy link
Owner Author

The timing would drift with this library, it doesn't support time synced shifting of more than one track. A change to soundtouch js would have to be done itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter playback speed?
3 participants