Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Atria and BBMAP #149

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Remove Atria and BBMAP #149

wants to merge 5 commits into from

Conversation

harmonbhasin
Copy link
Collaborator

After discussion with Will and Jeff, we've decided to remove ATRIA and BBMAP.

I updated this CHANGELOG under the assumption that we upload current dev to master, then merge this into dev.

Changes:

  • Remove ATRIA and BBMAP from the pipeline.

Changes in gold standard output:

  • virus_hits_db.tsv: 24 of the reads changed; with new we gained a read, and 3 out of the 24 had changes in read id. This can be attributed to removing Atria as it won’t be trimming some adapters.
  • virus_clade_counts.tsv: Total count of viruses went up one in the new output, which follows the understanding above. We see reads either going up one taxa or down one taxa.
  • virus_hits_1.fasta: There is one additional read in the new output which follows the above, and only a few of the other reads change in the front or end of their read, due to atria being removed (and hence adapters not being trimmed).
  • virus_hits_2.fast: Same trend as above.
  • blast_hits_paired.tsv: Two new reads are identified in the new output, due to the lack of adapter trimming, and for the rest of the reads, their taxid remains the same, but the BLAST metrics slightly change, which can be attributed to the addition of base pairs that are most likely from adapters.

CHANGELOG.md Outdated Show resolved Hide resolved
subworkflows/local/extractViralReads/main.nf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants