Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for S3 external layer #31

Merged
merged 9 commits into from
Jan 8, 2024

Conversation

nao1215
Copy link
Owner

@nao1215 nao1215 commented Jan 8, 2024

No description provided.

.github/workflows/linux_test.yml Show resolved Hide resolved
.github/workflows/linux_test.yml Show resolved Hide resolved
.github/workflows/linux_test.yml Show resolved Hide resolved
.github/workflows/linux_test.yml Outdated Show resolved Hide resolved
.github/workflows/linux_test.yml Outdated Show resolved Hide resolved
.github/workflows/linux_test.yml Outdated Show resolved Hide resolved
.github/workflows/linux_test.yml Outdated Show resolved Hide resolved
.github/workflows/linux_test.yml Outdated Show resolved Hide resolved
.github/workflows/mac_test.yml Outdated Show resolved Hide resolved
.github/workflows/windows_test.yml Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Jan 8, 2024

HOTTEST report

PASS FAIL SKIP TOTAL DURATION
262 0 7 269 7.409566115s

Reported by hottest

Copy link

github-actions bot commented Jan 8, 2024

Code Metrics Report

main (81047d1) #31 (16846df) +/-
Coverage 32.4% 37.0% +4.7%
Test Execution Time 13s 12s -1s
Details
  |                     | main (81047d1) | #31 (16846df) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          32.4% |         37.0% | +4.7% |
  |   Files             |             29 |            29 |     0 |
  |   Lines             |            955 |           967 |   +12 |
+ |   Covered           |            309 |           358 |   +49 |
+ | Test Execution Time |            13s |           12s |   -1s |

Code coverage of files in pull request scope (59.3% → 72.1%)

Files Coverage +/-
app/domain/model/domain.go 100.0% 0.0%
app/domain/model/s3.go 99.0% 0.0%
app/external/s3.go 41.4% +41.4%
app/external/s3_policy.go 0.0% 0.0%

Reported by octocov

@nao1215 nao1215 merged commit 0ab8c1f into main Jan 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant