Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove subcommand #10

Merged
merged 7 commits into from
Dec 29, 2023
Merged

Add remove subcommand #10

merged 7 commits into from
Dec 29, 2023

Conversation

nao1215
Copy link
Owner

@nao1215 nao1215 commented Dec 29, 2023

No description provided.

This comment has been minimized.

cmd/subcmd/common_test.go Outdated Show resolved Hide resolved
app/external/s3_retryer.go Outdated Show resolved Hide resolved
app/domain/model/s3.go Outdated Show resolved Hide resolved

This comment has been minimized.

cmd/subcmd/s3hub/rm.go Outdated Show resolved Hide resolved

This comment has been minimized.

Copy link

HOTTEST report

PASS FAIL SKIP TOTAL DURATION
100 0 4 104 1.345179573s

Reported by hottest

Copy link

Code Metrics Report

main (89110b0) #10 (c6e78d6) +/-
Coverage 19.6% 16.9% -2.7%
Test Execution Time 2s 3s +1s
Details
  |                     | main (89110b0) | #10 (c6e78d6) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          19.6% |         16.9% | -2.7% |
  |   Files             |             19 |            20 |    +1 |
  |   Lines             |            403 |           599 |  +196 |
+ |   Covered           |             79 |           101 |   +22 |
- | Test Execution Time |             2s |            3s |   +1s |

Code coverage of files in pull request scope (16.9% → 14.7%)

Files Coverage +/-
app/di/wire_gen.go 0.0% 0.0%
app/domain/model/s3.go 80.3% -13.3%
app/external/s3.go 0.0% 0.0%
app/external/s3_retryer.go 0.0% 0.0%
app/interactor/s3.go 0.0% 0.0%
cmd/subcmd/common.go 80.0% +80.0%
cmd/subcmd/s3hub/ls.go 0.0% 0.0%
cmd/subcmd/s3hub/mb.go 0.0% 0.0%
cmd/subcmd/s3hub/rm.go 0.0% -100.0%
ui/s3hub.go 0.0% 0.0%
utils/errfmt/errfmt.go 100.0% 0.0%

Reported by octocov

@nao1215 nao1215 merged commit f284b38 into main Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant