This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Statically link to the Rust library #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ejpcmac thank you for your contribution. Before i can merge this, we have to make sure, that it works together with the https://github.com/signal-golang/textsecure/cmd/textsecure |
|
@nanu-c Sure! It works on my side. What should I do in the other repo? Update the |
The Rust library was previously statically linked, which meant we had to install the library to be able to run dependent application. Frow now, it will be statically linked to the final binary, enhancing the developer’s and packager’s expercience. I’ve also added a Makefile to prebuild the library, and updated the instructions in the README.md
ejpcmac
force-pushed
the
static-rust-lib
branch
from
ffec98d to
2c7273e
Compare
|
I’ve rebased on top of your last changes, and I’m now running the latest Axolotl with groups v2 support linked statically to zkgroup on my PinePhone. I’ve seen a warning when linking however, so I’ll investigate later today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust library was previously statically linked, which meant we had to install the library to be able to run dependent application. Frow now, it will be statically linked to the final binary, enhancing the developer’s and packager’s expercience.
I’ve also added a Makefile to prebuild the library, and updated the instructions in the
README.md.To ease a bit more the setup of an environment, I’ve commited my
shell.nixand added instruction to run the Nix shell. If you don’t want this in your repo, or you are OK with it but don’t want the instructions in theREADME.md, just let me know and I’ll reset the branch prior to my last commit.