Skip to content

Fixed parsing raw string literals #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed parsing raw string literals #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Lexer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,12 @@ class StreamLexer {
}
this._current += 1;
const literal = stream.slice(start + 1, this._current - 1);
return literal.replace(`\\'`, `'`);

// emulating es2021: String.prototype.replaceAll()
return literal
.split(`\\\\`).join(`\\`)
.split(`\\'`).join(`'`)
;
}

private consumeNumber(stream: string): LexerToken {
Expand Down
12 changes: 12 additions & 0 deletions test/jmespath.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,18 @@ describe('tokenize', () => {
it('should tokenize json literals', () => {
expect(tokenize('`true`')).toMatchObject([{ type: 'Literal', value: true, start: 0 }]);
});
it('should tokenize raw strings', () => {
expect(tokenize("'raw-string'")).toMatchObject([{ type: 'Literal', value: "raw-string", start: 0 }]);
});
it('should tokenize raw strings single quote', () => {
expect(tokenize("'\\''")).toMatchObject([{ type: 'Literal', value: "'", start: 0 }]);
});
it('should tokenize raw strings surrounding quotes', () => {
expect(tokenize("'\\'raw-string\\''")).toMatchObject([{ type: 'Literal', value: "'raw-string'", start: 0 }]);
});
it('should tokenize raw strings backslash characters', () => {
expect(tokenize("'\\\\'")).toMatchObject([{ type: 'Literal', value: "\\", start: 0 }]);
});
it('should not requiring surrounding quotes for strings', () => {
expect(tokenize('`foo`')).toMatchObject([{ type: 'Literal', value: 'foo', start: 0 }]);
});
Expand Down
Loading