Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an nbin option to photonphase #1863

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

matteobachetti
Copy link
Contributor

@matteobachetti matteobachetti commented Nov 19, 2024

Allow photonphase to plot a pulse profile with a custom number of bins, while maintaining the current value as default

E.g. 256 bins
256 bins

versus default
100 bins

Allow photonphase to plot a pulse profile with a custom number of bins, while maintaining the current value as default
@paulray
Copy link
Member

paulray commented Nov 21, 2024

Sure, looks good!

@abhisrkckl
Copy link
Contributor

Please add a CHANGELOG.

@matteobachetti
Copy link
Contributor Author

Done!

@abhisrkckl abhisrkckl merged commit 3de943c into nanograv:master Nov 22, 2024
7 checks passed
@matteobachetti matteobachetti deleted the patch-4 branch November 23, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants