Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an undefined name #1630

Conversation

munahaf
Copy link
Contributor

@munahaf munahaf commented Aug 29, 2023

In file: tcb_conversion.py, the list named __all__ contains an undefined name which can result in errors when this module is imported. I removed the undefined name from the list. For more information regarding __all__, please read about importing fields from a package.

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF)(https://openssf.org/): Project Alpha-Omega(https://alpha-omega.dev/). Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

@abhisrkckl
Copy link
Contributor

Please change convert_tcb_to_tdb to convert_tcb_tdb instead of deleting it. There is a convert_tcb_tdb function in this module.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e73a86a) 68.25% compared to head (8c63186) 68.26%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   68.25%   68.26%           
=======================================
  Files          99       99           
  Lines       22784    22791    +7     
  Branches     3916     3920    +4     
=======================================
+ Hits        15551    15558    +7     
+ Misses       6273     6272    -1     
- Partials      960      961    +1     
Files Changed Coverage Δ
src/pint/models/tcb_conversion.py 83.92% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl abhisrkckl merged commit 2e21738 into nanograv:master Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants