Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication output #1621

Merged
merged 35 commits into from
Sep 21, 2023
Merged

Publication output #1621

merged 35 commits into from
Sep 21, 2023

Conversation

abhisrkckl
Copy link
Contributor

No description provided.

@abhisrkckl abhisrkckl linked an issue Aug 21, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 88.52% and project coverage change: +0.15% 🎉

Comparison is base (5b2c911) 68.29% compared to head (8f7792e) 68.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
+ Coverage   68.29%   68.45%   +0.15%     
==========================================
  Files         100      102       +2     
  Lines       23119    23301     +182     
  Branches     4011     4049      +38     
==========================================
+ Hits        15789    15950     +161     
- Misses       6341     6351      +10     
- Partials      989     1000      +11     
Files Changed Coverage Δ
src/pint/models/absolute_phase.py 95.83% <ø> (ø)
src/pint/models/binary_ell1.py 86.00% <ø> (ø)
src/pint/models/frequency_dependent.py 83.09% <ø> (ø)
src/pint/models/jump.py 76.66% <ø> (ø)
src/pint/models/noise_model.py 94.03% <ø> (ø)
src/pint/models/pulsar_binary.py 77.51% <ø> (ø)
src/pint/scripts/pintempo.py 81.42% <ø> (ø)
src/pint/models/parameter.py 82.22% <74.19%> (-0.29%) ⬇️
src/pint/output/publish.py 89.51% <89.51%> (ø)
src/pint/models/spindown.py 85.86% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulray
Copy link
Member

paulray commented Aug 22, 2023

Can you add an example of the rendered output PDF, here in the PR?

@abhisrkckl
Copy link
Contributor Author

Here is a wideband example:

$ pintpublish J1614-2230_NANOGrav_12yv3.wb.gls.par J1614-2230_NANOGrav_12yv3.wb.tim --outfile J1614-2230_NANOGrav_12yv3.wb.tex 
$ pdflatex J1614-2230_NANOGrav_12yv3.wb.tex

J1614-2230_NANOGrav_12yv3.wb.pdf

@abhisrkckl
Copy link
Contributor Author

Here is a narrowband example:

$ pintpublish B1855+09_NANOGrav_9yv1.gls.par B1855+09_NANOGrav_9yv1.tim --outfile B1855+09_NANOGrav_9yv1.tex 
$ pdflatex B1855+09_NANOGrav_9yv1.tex

B1855+09_NANOGrav_9yv1.pdf

@paulray
Copy link
Member

paulray commented Aug 22, 2023

Looks good! Some small suggestions:

  • In the parameter values, the "-" signs should be in math mode so they render as minus signs rather than hyphens.
  • I don't love "2.3e-16" for scientific notation. Could we use "$2.3 \times 10^{-16}$"?

@abhisrkckl
Copy link
Contributor Author

I have implemented latex formatting for numbers and units. Now the output looks like this
image

@paulray
Copy link
Member

paulray commented Aug 22, 2023

I like the LaTeX formatting! The only change I'd make is us ApJ style of "mas yr$^{-1}$" instead of the fraction.

@abhisrkckl
Copy link
Contributor Author

Disabled fraction.
image

@abhisrkckl abhisrkckl changed the title WIP: Publication output Publication output Aug 22, 2023
@paulray paulray merged commit f4cbedc into nanograv:master Sep 21, 2023
8 checks passed
@abhisrkckl abhisrkckl deleted the publish branch May 14, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publication output
2 participants