Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The format for 64bit values is "ll" not "l" #848

Merged
merged 1 commit into from
Sep 9, 2018
Merged

The format for 64bit values is "ll" not "l" #848

merged 1 commit into from
Sep 9, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

Description

That fixes issue #399: ToString methods of ulong/UInt64 and long/Int64 are not returning the correct values

Motivation and Context

How Has This Been Tested?

I've tested that with the C# program from the issue. Now it returns the correct values.

Screenshots

From console output:

12345678998765432101
AB54A9A3A069ED25
-1234567899876543210
EEDDEF093CC23516

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch [email protected]

That fixes issue #399: ToString methods of ulong/UInt64 and long/Int64 are not returning the correct values

Signed-off-by: Matthias Jentsch <[email protected]>
@nfbot
Copy link
Member

nfbot commented Sep 8, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Sep 9, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! This probably would have been caught earlier with code review...

@MatthiasJentsch MatthiasJentsch merged commit 0336b97 into nanoframework:develop Sep 9, 2018
@MatthiasJentsch MatthiasJentsch deleted the Fix399 branch September 9, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToString methods of ulong/UInt64 and long/Int64 are not returning the correct values
3 participants