Uncommented the CLR_RT_TypeSystem::FindTypeDef functionality

[MatthiasJentsch]

Description

Uncommented the CLR_RT_TypeSystem::FindTypeDef functionality
That fixes issue #397
Why was that commented out?

Motivation and Context

• Fixes Assembly.GetType returns null Home#397
• Fixes Type.GetType returns null at least for types from the current assembly Home#404

How Has This Been Tested?

using System;
using System.Reflection;

namespace NFApp1
{
	public class Program
	{
		public static void Main()
		{
			Assembly a = Assembly.GetAssembly(typeof(Program));
			string fn = typeof(Program).FullName;
			Type t = a.GetType(fn);
		}
	}
}

In the last line is t now not null. It's set to the correct type.

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Signed-off-by: Matthias Jentsch [email protected]

[nfbot]

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

[josesimoes]

LGTM

[josesimoes]

Why was that commented out?

Don't know exactly. But from that UNDOME FIXME comment there I guess there was something preventing that code from working. That is, when the code was being added
. Probably those calls to Hal strcpy and such, which weren't available at that time...