Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNTP fixes for ESP32 #838

Merged
merged 1 commit into from
Sep 5, 2018
Merged

SNTP fixes for ESP32 #838

merged 1 commit into from
Sep 5, 2018

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Sep 4, 2018

Description

Added code to automatically start SNTP when we receive an IP address for Wireless or Ethernet connection.
Fix an issue where we were getting the time from the system ticks where it should have been RTC via
gettimeofday().

How Has This Been Tested?

DIsplayed the date / time ever second after connecting to wireless network. After 12 secs the date/time was correct from SNTP

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented Sep 4, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets labels Sep 4, 2018
@AdrianSoundy AdrianSoundy merged commit dffde7b into nanoframework:develop-network Sep 5, 2018
@AdrianSoundy AdrianSoundy deleted the SNTP branch September 5, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants