Fix single precision Truncate___STATIC__R4__R4 #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single precision Truncate function in corlib math incorrectly returned the fractional part instead of the integral part. Fix (issue nanoframework#392 reported in home repo) Signed-off-by: NemesisXB <[email protected]>
|
Hi @NemesisXB, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
|
|
josesimoes
approved these changes
Sep 3, 2018
josesimoes
added
Type: bug
Area: Common libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix SP Truncate in native corlib math
Motivation and Context
The single precision Truncate function in corlib math incorrectly returned the fractional part instead of the integral part.
How Has This Been Tested?
Reproduced bug using STM32F429I-Discovery board.
Updated the CLR and tested with same test code, this time getting the expected result
Screenshots
Types of changes
Checklist:
Signed-off-by: NemesisXB [email protected]