Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CLR_SETTINGS to targets #832

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • This allows a developer to define CLR settings per target. Until they those were common and couldn't be changed for a specific target.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds labels Aug 29, 2018
@nfbot
Copy link
Member

nfbot commented Aug 29, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit f172d94 into nanoframework:develop Aug 29, 2018
@josesimoes josesimoes deleted the move-clr-settings-to-targets branch August 29, 2018 01:47
clrSettings.EnterDebuggerLoopAfterExit = true;

ClrStartup(clrSettings);
ClrStartup(*clrSettings);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdrianSoundy or @MatthiasJentsch please confirm that this is working as expected. Thanks!

josesimoes added a commit to nanoframework/nf-Community-Targets that referenced this pull request Aug 29, 2018
josesimoes added a commit to nanoframework/nf-Community-Targets that referenced this pull request Aug 29, 2018
piwi1263 pushed a commit to nanoframework/nf-Community-Targets that referenced this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants