Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve posting of managed events #830

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Improves performance by only posting event if there are subscribers
  • Not possible for UART though as ChibiOS is missing args in UART callback (see here).

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- This is for SMT32 Gpio, currently not possible with UART because ChibiOS is missing args in UART callbacks

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Aug 27, 2018
@nfbot
Copy link
Member

nfbot commented Aug 27, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit d9810aa into nanoframework:develop Aug 27, 2018
@josesimoes josesimoes deleted the improve-posting-managed-events branch August 29, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants