Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tiny printf implementation #813

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fix tiny printf implementation #813

merged 1 commit into from
Aug 6, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Replace with vsnprintf
  • Correct old format hal_nnn with correct replacements from standard printf calls

Motivation and Context

  • Fixes issues with bad/wrong output from printf related calls

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Fix tiny printf implementation
4039917 
- Replace with vsnprintf
- Correct old format hal_nnn with correct replacements from standard printf calls

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Area: Common libs Everything related with common libraries labels Aug 6, 2018
@nfbot
Copy link
Member

nfbot commented Aug 6, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 279df1b into nanoframework:develop Aug 6, 2018
@josesimoes josesimoes deleted the fix-tiny-printf branch August 6, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot