Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up messaging class #799

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Clean-up messaging class #799

merged 1 commit into from
Jul 19, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Messaging class was simplified but the code was never clean-up
  • Remove messaging port
  • Update HalSystemConfig on all targets to remove messaging port

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Clean-up messaging class
72861f3 
- Messaging class was simplified but the code was never clean-up
- Remove messaging port
- Update HalSystemConfig on all targets to remove messaging port

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Area: Common libs Everything related with common libraries labels Jul 19, 2018
@nfbot
Copy link
Member

nfbot commented Jul 19, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 7ef254a into nanoframework:develop Jul 19, 2018
@josesimoes josesimoes deleted the cleanup-messaging branch July 19, 2018 16:34
josesimoes added a commit to nanoframework/nf-Community-Targets that referenced this pull request Jul 19, 2018
@josesimoes
Remove messaging port from HAL confih
979d64b 
- Following nanoframework/nf-interpreter#799

Signed-off-by: José Simões <[email protected]>

#ALL#
@josesimoes josesimoes mentioned this pull request Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Area: Interpreter Everything related with the interpreter, execution engine and such Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot