Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configurable Wire Protocol packet size #784

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jul 16, 2018

Description

  • Add enum for various packet sizes
  • Update code for booter and debugger to check for WP packet size definition from target_common.h, if not found default to the historic 1024 size
  • Improve declaration of buffer to maximum possible size instead of using twice the payload size (which was a waste of RAM)

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Jul 16, 2018
@nfbot
Copy link
Member

nfbot commented Jul 16, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 254ea36 into nanoframework:develop Jul 16, 2018
@josesimoes josesimoes deleted the work-362 branch July 16, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smaller/configurable Wire Protocol payload buffer
2 participants