Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed build back to Debug #783

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Changed build back to Debug #783

merged 1 commit into from
Jul 3, 2018

Conversation

AdrianSoundy
Copy link
Member

Description

Due to problems running the MinSizeRel configuration type have reverted back to debug until problems are resolved.

How Has This Been Tested?

Tested debug build works with VS extension. MinSizeRel is not working with extension.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented Jul 3, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@MatthiasJentsch
Copy link
Contributor

LGTM. Hopefully we will find the reason for it soon.

MatthiasJentsch
MatthiasJentsch approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@MatthiasJentsch MatthiasJentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthiasJentsch MatthiasJentsch merged commit efff69a into nanoframework:develop Jul 3, 2018
@AdrianSoundy AdrianSoundy deleted the Debug-build branch July 3, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthiasJentsch MatthiasJentsch MatthiasJentsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @MatthiasJentsch