Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add managed event on serial communication #766

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Add managed event on serial communication #766

merged 1 commit into from
Jun 26, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 26, 2018 •
edited
Loading

Description

🚧 ** WIP for ESP32 implementation ** 🚧

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Area: Common libs Everything related with common libraries labels Jun 26, 2018
@nfbot
Copy link
Member

nfbot commented Jun 26, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Add managed event on serial communication
d8fc9f6 
- Add new PAL event EVENT_SERIAL
- Update rx callback to fire managed event or imidiate return on detection of watch char
- Update declaration of native assembly supporting nanoframework/Windows.Devices.SerialCommunication#25

** WIP for ESP32 implementation **

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit 28ee09a into nanoframework:develop Jun 26, 2018
@josesimoes josesimoes deleted the work-285 branch June 26, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serial communication event on incoming/receiving data
2 participants
@josesimoes @nfbot