Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for timeout errors on I2C introduced with 3.0 release. #746

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Fix for timeout errors on I2C introduced with 3.0 release. #746

merged 1 commit into from
Jun 15, 2018

Conversation

AdrianSoundy
Copy link
Member

Description

Also fixed read/write flag

Motivation and Context

Broken with the IDF 3.0 release

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented Jun 15, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great that you've managed to find the cause.

@josesimoes josesimoes merged commit 32ca0e9 into nanoframework:develop Jun 15, 2018
@AdrianSoundy AdrianSoundy deleted the I2c-fix branch June 15, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants