Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADC declaration on all targets 🚧 #736

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Can't use NULL for uint8_t (pin field)

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- Can't use NULL for uint8_t (pin field)

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Jun 7, 2018
@nfbot
Copy link
Member

nfbot commented Jun 7, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 78b0960 into nanoframework:develop Jun 7, 2018
@josesimoes josesimoes deleted the fix-adc-declaration branch June 7, 2018 11:13
josesimoes added a commit to nanoframework/nf-Community-Targets that referenced this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants