Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all IRAM_ATTR attributes #718

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Removed all IRAM_ATTR attributes #718

merged 1 commit into from
Jun 4, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

Description

Removed all IRAM_ATTR attributes because it's not needed in production code.

Motivation and Context

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch [email protected]

@nfbot
Copy link
Member

nfbot commented Jun 3, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets labels Jun 3, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianSoundy AdrianSoundy merged commit eb596d6 into nanoframework:develop Jun 4, 2018
@MatthiasJentsch MatthiasJentsch deleted the Fix328 branch June 5, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate need for the IRAM_ATTR attribute
4 participants