GLOBAL_LOCK / GLOBAL_UNLOCK implemented #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a solution here: https://esp32.com/viewtopic.php?t=1703#p7918 We can use taskENTER_CRITICAL / taskEXIT_CRITICAL Signed-off-by: Matthias Jentsch <[email protected]>
|
Hi @MatthiasJentsch, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
added
Type: enhancement
Series: ESP32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GLOBAL_LOCK / GLOBAL_UNLOCK was not implemented for the ESP32 target until now. I found a solution here: https://esp32.com/viewtopic.php?t=1703#p7918
We can use taskENTER_CRITICAL / taskEXIT_CRITICAL
Motivation and Context
After talking with @AdrianSoundy he mentioned that the GLOBAL_LOCK / GLOBAL_UNLOCK was not implemented for the ESP32 target. So I found a solution for it and implemented it via taskENTER_CRITICAL / taskEXIT_CRITICAL. With these calls the interrupts are disabled/enabled for critical regions that should not be interrupted by others.
Types of changes
Checklist:
Signed-off-by: Matthias Jentsch [email protected]