Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in ESP32 related docs #691

Merged
merged 1 commit into from
May 17, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Correct path to bin file in build directory (it's right at the build folder no need to go into targets)
  • Update default baud rate to 921600
  • Improve layout and format on build instructions
  • Correct casing on several docs

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

- Correct path to bin file in build directory (it's right at the build folder no need to go into targets)
- Update default baud rate to 921600
- Improve layout and format on build instructions
- Correct casing on several docs

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes added Type: documentation Series: ESP32 Everything related specifically with ESP32 series targets labels May 17, 2018
@nfbot
Copy link
Member

nfbot commented May 17, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit a905c92 into nanoframework:develop May 17, 2018
@josesimoes josesimoes deleted the improve-esp32-doc branch May 17, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants