Work on PAL events and PAL time #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename PAL events timer to improve clarity - Correct bug in Events_WaitForEvents: wrong call to HAL_Time_CurrentSysTicks instead of HAL_Time_CurrentTime because nF ticks are required for HAL_COMPLETION - Events_WaitForEvents is now using OS Yield instead of OS Wait for a smoother execution - Rework PAL time by using a timer with callback to schedule HAL_COMPLETION events instead of checking for that on every sysTick - Remove Time_Interrupt_Hook() from CH_CFG_SYSTEM_TICK_HOOK (not required anymore) - Rename some argumens to improve clarity - Clean up code in PAL events for ESP32 Signed-off-by: josesimoes <[email protected]>
josesimoes
added
Type: enhancement
Area: Interpreter
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
|
@MatthiasJentsch and @ishvedov appreciate if you could give a try with this PR for ESP32. Thanks! |
Signed-off-by: josesimoes <[email protected]>
josesimoes
force-pushed
the
rework-on-events
branch
from
536e6fc
to
9800e43
Compare
|
@josesimoes working with little performance degradation. Or may be my test faulted. |
|
OK. Thanks. 👍 |
|
I'm not sure how to test this. @ishvedov how did you test it? |
|
@MatthiasJentsch, go to Slack. |
|
I'm now able to test this with ESP32. It's performing as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by: josesimoes [email protected]