Fix to ADC last change to managed code #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Pwm, Adc and Network into Appveyor builds Disable logging from IDF which caused a 2nd deploy to fail Add missing file in Makelist for network builds Fix to GPIO where some pins not working as gpio is alternate function. Calling config instead of separate methods also assigns the correct function to pin.
After change to managed ADC code to make 1 logical ADC the ESP32 port no longer worked. Code now updated to support 1 ADC unit Added the ESP32 internal temperture sensor as channel 8 Internal Hall sensor is channel 9
|
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
approved these changes
Apr 8, 2018
josesimoes
added
Type: enhancement
Series: ESP32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After change to managed ADC code to make 1 logical ADC the ESP32 port no longer worked.
Code now updated to support 1 ADC unit
Added the ESP32 internal temperature sensor as channel 8
Internal Hall sensor is channel 9
How Has This Been Tested?
Tested with ADC test sample
Types of changes
Checklist:
Signed-off-by: adriansoundy[email protected]